Skip to content

[Fix] Failing test #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2024
Merged

[Fix] Failing test #912

merged 1 commit into from
Sep 19, 2024

Conversation

@mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Sep 19, 2024 •
edited
Loading

Test

huggingface.js/packages/inference/test/HfInference.spec.ts

Lines 49 to 50 in 21e63ff

it("works without model", async () => {
expect(
has been failing.

Probably related to canonical model hf.co/bert-base-uncased moving to hf.co/google-bert/bert-base-uncased

@mishig25 mishig25 requested a review from vvmnnnkv as a code owner September 19, 2024 12:36
julien-c
julien-c approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mishig25 mishig25 merged commit ed90897 into main Sep 19, 2024
5 checks passed
@mishig25 mishig25 deleted the fix_failing_test branch September 19, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-c julien-c julien-c approved these changes

@vvmnnnkv vvmnnnkv Awaiting requested review from vvmnnnkv

@coyotte508 coyotte508 Awaiting requested review from coyotte508

@osanseviero osanseviero Awaiting requested review from osanseviero

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mishig25 @julien-c